Handle condition with always true/false sub-condition #3313
Conversation
|
You've opened the pull request against the latest branch 1.12.x. If your code is relevant on 1.11.x and you want it to be released sooner, please rebase your pull request and change its target to 1.11.x. |
VincentLanglet
force-pushed
the
improveTypeSpecificer
branch
from
d97af04 to
072168e
Compare
VincentLanglet
force-pushed
the
improveTypeSpecificer
branch
from
3b4d594 to
87b3684
Compare
| $this->createFunctionCall('is_string', 'bar'), | ||
| ), | ||
| [], | ||
| ['$foo' => 'int'], |
There was a problem hiding this comment.
Since bar is an object
$this->scope = $this->scope->assignVariable('bar', new ObjectType('Bar'), new ObjectType('Bar'));
we can be sure foo is an int.
I added the same test with is_int($foo) || is_string($mixed) to reproduce the old behavior.
| [ | ||
| new Expr\Empty_(new Variable('array')), | ||
| [ | ||
| '$array' => 'array{}|null', |
There was a problem hiding this comment.
Since array is defined as an non nullable array
$this->scope = $this->scope->assignVariable('array', new ArrayType(new MixedType(), new MixedType()), new ArrayType(new MixedType(), new MixedType()));
we can be sure it's an array.
|
@VincentLanglet do you remember why you closed this PR? I think this fix would be useful to fix a few of the ~1200 errors |
No I don't... Maybe it wasn't working ? You can try to reopen it on 2.1.x to see the result of the build |
3 participants
Closes phpstan/phpstan#11276